At 12:15 AM +0200 7/23/04, Richard Levitte - VMS Whacker wrote:
>Hello,

Welcome back.

[ File::Spec->splitpath problems snipped ]

>As can be seen, there are things that don't really happen, like
>[BAR.COOKIE.BANANA.--] only got changed to [BAR.COOKIE.-], not [BAR]
>(basically, the current VMS.pm doesn't handle multiple dashes very
>well).  Also, I noticed that things like FOO.000000] would be
>converted to FOO], which I think is an absolute no-no (you CAN have a
>000000.DIR), only [000000.][, .][000000] and [000000. should be
>reduced.  While I'm at it, < and > should be changed to [ and ].
>
>My patch (attached as VMD.pm.diff, produced with diff -u) makes the
>above errors go away.  I've based the things I do on a decade of
>experience with VMS, having hacked similar things a long time ago in
>GNU emacs and so on.

Excellent.  I've long thought that section of code looked crufty and
needed an overhaul.  Just for the record, what version of Perl are
you using?  Did you rerun the entire test suite after your patch and
see any failures?  I will run some tests in any case just to make
sure nothing is depending on the broken behavior.

-- 
________________________________________
Craig A. Berry
mailto:[EMAIL PROTECTED]

"... getting out of a sonnet is much more
 difficult than getting in."
                 Brad Leithauser

Reply via email to