# recover this item within the current parent
my $parentinfo = $physinfo->{parents}->{$row->{parentphys}};
- if (undef $parentinfo->{deleted}) {
+ if (!defined $parentinfo->{deleted}) {
$self->{errmsg} .= "Attempt to recover an active item
'$physname':\n"
. "$self->{physname_seen}\n";
I just noticed this line... regardless of the rest of the patch, you
definitely don't want to be doing an undef there; undef will un-define
a variable, not test for whether it's defined.
;-) This "wrong" check was in the code since ages. I was wondering
myself, how this could have ever worked. I just came across this line
and fixed it on the way. I have no idea, what will change for people
running the conversion. I expect that this is of minor impact, since the
undef is done anyway one line later. So it could be a problem in a
szenario, where we had missed a prior delete.
Dirk
_______________________________________________
vss2svn-users mailing list
Project homepage:
http://www.pumacode.org/projects/vss2svn/
Subscribe/Unsubscribe/Admin:
http://lists.pumacode.org/mailman/listinfo/vss2svn-users-lists.pumacode.org
Mailing list web interface (with searchable archives):
http://dir.gmane.org/gmane.comp.version-control.subversion.vss2svn.user
