Looks mostly good, just a few comments, some not very relevant.
On Friday, 29 September 2006 at 19:22, Dennis Schridde wrote:
> @@ -3125,7 +3121,7 @@
>
> //create the message filename
> aFileName[fileExtension] = '\0';
> - strcat(aFileName, "mFlagState.bjo");
> + strcat(aFileName, "mflagsstate.bjo");
> /*Write the data to the file*/
> if (!writeFlagFile(aFileName))
> {
Typo (one 's' too much)?
> @@ -588,7 +588,7 @@
>
> else
> if(IsEqualGUID(&(NetPlay.protocols[id-CON_TYPESID_START].guid),
> &SPGUID_MPLAYER) ) // mplayer
> {
> - if(system("multiplay\\MplayNow\\mplaynow.exe") != -1)
> // launch gizmo, if present. If not, tough...
> + if(system("multiplay/MplayNow/mplaynow.exe") != -1)
> // launch gizmo, if present. If not, tough...
> {
> changeTitleMode(QUIT);
> // shut down warzone...
> }
That looks a bit outdated and very Windows-centric.
> Index: src/frontend.c
> ===================================================================
> --- src/frontend.c (revision 412)
> +++ src/frontend.c (working copy)
> @@ -511,7 +511,7 @@
> strcpy(pLevelName,DEFAULT_LEVEL);
> seq_ClearSeqList();
>
> -
> seq_AddSeqToList("CAM1\\c001.rpl",NULL,"CAM1\\c001.txa",FALSE,0);
> +
> seq_AddSeqToList("CAM1/c001.rpl",NULL,"CAM1/c001.txa",FALSE,0);
>
> seq_StartNextFullScreenVideo();
> break;
Have you intentionally left the directories out (there were a few more)?
> Index: src/intelmap.c
> ===================================================================
> --- src/intelmap.c (revision 412)
> +++ src/intelmap.c (working copy)
> @@ -1160,7 +1160,7 @@
> {
> ASSERT( strlen(((VIEW_RESEARCH *)((VIEWDATA
> *)psMessage->pViewData)->
> pData)->pAudio)<244,"sequence path+name
> greater than max string" );
> - strcpy(aAudioName,"sequenceAudio\\");
> + strcpy(aAudioName,"sequenceAudio/");
> strcat(aAudioName,((VIEW_RESEARCH *)((VIEWDATA
> *)psMessage->
> pViewData)->pData)->pAudio);
>
This and the following, for example.
> Index: src/mission.c
> ===================================================================
> --- src/mission.c (revision 412)
> +++ src/mission.c (working copy)
> @@ -575,9 +575,9 @@
> //play the cam 2 video
> seq_ClearSeqList();
> #ifndef PSX
> -
> seq_AddSeqToList("CAM2\\c002.rpl",NULL,"CAM2\\c002.txa",FALSE);
> +
> seq_AddSeqToList("CAM2/c002.rpl",NULL,"CAM2/c002.txa",FALSE);
> #else
> - seq_AddSeqToList("CAM2\\C002.STR","1656f");
> + seq_AddSeqToList("CAM2/C002.STR","1656f");
> #endif
> seq_StartNextFullScreenVideo();
> }
> @@ -586,10 +586,10 @@
> //play the cam 3 video
> seq_ClearSeqList();
> #ifndef PSX
> -
> seq_AddSeqToList("CAM2\\cam2out.rpl",NULL,NULL,FALSE);
> -
> seq_AddSeqToList("CAM3\\c003.rpl",NULL,"CAM3\\c003.txa",FALSE);
> +
> seq_AddSeqToList("CAM2/cam2out.rpl",NULL,NULL,FALSE);
> +
> seq_AddSeqToList("CAM3/c003.rpl",NULL,"CAM3/c003.txa",FALSE);
> #else
> - seq_AddSeqToList("CAM3\\C003.STR","1656f");
> + seq_AddSeqToList("CAM3/C003.STR","1656f");
> #endif
> seq_StartNextFullScreenVideo();
> }*/
Why do we still have PSX stuff in there?
_______________________________________________
Warzone-dev mailing list
[email protected]
https://mail.gna.org/listinfo/warzone-dev
