Hello everyone,
Here are a few comments and things I've noticed recently:
- In the trunk the selection box is filled with a transparent overlay,
which is 1 pixel too narrow and too low. The first attached patch
fixes that, but the actual error might be hidden somewhere deeper.
- The attached patch also disables the pulsing of the selection box. I
think the pulsing is irritating, since the selection box usually isn't
even on-screen for one pulse cycle (at least for my usage). That part
is mainly a request for comments and should be made configurable.
- The radar view indicator fix and possibly the fixed selection box
patch could both be applied to 2.0.
- 2.0 doesn't include some of the g++ fixes, thus RegFilePath is defined
twice. That might be the cause of the empty config file problem, the
second attached patch fixes the double definition.
- When using the Windows installer for 2.0.5 as a regular user, when
selecting a write-protected directory the installer just aborts
instead of offering to select another directory.
- The german description of Grim's graphics update in the installer was
somewhat strange.
--
Does the name Pavlov ring a bell?
=== src/display3d.c
==================================================================
--- src/display3d.c (revision 733)
+++ src/display3d.c (local)
@@ -3476,11 +3476,13 @@
minY = min(dragBox3D.y1, mY);
maxY = max(dragBox3D.y1, mY);
+#if 0
// SHURCOOL: Reduce the box in size to produce a (consistent) pulsing inward effect
minX += dragBox3D.boxColourIndex/2;
maxX -= dragBox3D.boxColourIndex/2;
minY += dragBox3D.boxColourIndex/2;
maxY -= dragBox3D.boxColourIndex/2;
+#endif
pie_SetDepthBufferStatus(DEPTH_CMP_ALWAYS_WRT_OFF);
iV_Box(minX, minY,
@@ -3489,7 +3491,7 @@
if (war_GetTranslucent())
{
pie_UniTransBoxFill(minX+1, minY+1,
- maxX-1, maxY-1,
+ maxX, maxY,
0x00ffffff, 16);
}
pie_SetDepthBufferStatus(DEPTH_CMP_LEQ_WRT_ON);
=== src/main.c
==================================================================
--- src/main.c (revision 717)
+++ src/main.c (revision 718)
@@ -22,6 +22,7 @@
*
*/
#include "lib/framework/frame.h"
+#include "lib/framework/configfile.h"
/* For SHGetFolderPath */
#if defined(WIN32)
@@ -104,7 +105,6 @@
char MultiPlayersPath[MAX_PATH];
char KeyMapPath[MAX_PATH];
char UserMusicPath[MAX_PATH];
-char RegFilePath[MAX_PATH];
void debug_callback_stderr( void**, const char * );
void debug_callback_win32debug( void**, const char * );
=== lib/framework/configfile.h
==================================================================
--- lib/framework/configfile.h (revision 717)
+++ lib/framework/configfile.h (revision 718)
@@ -28,3 +28,5 @@
extern BOOL setWarzoneKeyNumeric (STRING *pName,SDWORD val);
extern BOOL getWarzoneKeyString(STRING *pName, STRING *pString);
extern BOOL setWarzoneKeyString(STRING *pName, STRING *pString);
+
+extern char RegFilePath[MAX_PATH];
_______________________________________________
Warzone-dev mailing list
[email protected]
https://mail.gna.org/listinfo/warzone-dev
