On 8/24/08, Per Inge Mathisen <[EMAIL PROTECTED]> wrote: > > See http://wiki.wz2100.net/Commit_guidelines
About these guidelines, take this: " Patches as a rule go into the patch tracker. Give a quick run down of what it does and what it changes." Does it matter which tracker? The Trac tracker is *much* better, (no need to download the patch to see what it does, it shows a color coded diff view as well, so you can see what it changes also). That means that reviewing said patches is about 100% easier on http://developer.wz2100.net/ than on GNA's tracker. The only thing missing on Trac is that it isn't setup to e-mail the ML about it, but it does spam the IRC channel with the info. " Patches that only fix bugs (no rewrites which fix bugs...) or build errors can go in at once." What do you mean by that? Most of the time you have to rewrite some stuff to fix the bug, unless you mean really simple errors that involve less than a few lines? Case in point, my next patch fixes a long standing bug, but I needed to rewrite the logic so the bug wouldn't occur. What about other patches that aren't really code changes per se, they just change comments and or add things to debug statements? Another of my patches deals with making the game more 'mod' friendly, in that, in the debug statements that are already there, I add a function that gets the real directory information that physfs is using. (That is how I found bug https://gna.org/bugs/?12053 ) And then we got patches in the tracker that are many months old. Since it has been longer than 48 hours, those are ok to integrate? And finally, you should also add a 'modify the changelog when patch is integrated' rule. Unless we go with just svn log dumps of what was done? Also, more descriptive comments in the svn log while committing would also be a good rule.
_______________________________________________ Warzone-dev mailing list [email protected] https://mail.gna.org/listinfo/warzone-dev
