On Mon, Aug 25, 2008 at 5:03 AM, bugs buggy <[EMAIL PROTECTED]> wrote: > About these guidelines, take this: > > " Patches as a rule go into the patch tracker. Give a quick run down of what > it does and what it changes." > > Does it matter which tracker?
No. But if the tracker doesn't email the list, please do so manually. > " Patches that only fix bugs (no rewrites which fix bugs...) or build errors > can go in at once." > > What do you mean by that? Most of the time you have to rewrite some stuff > to fix the bug, unless you mean really simple errors that involve less than > a few lines? If the fix is a few lines, fine. If you have to rewrite a lot of code (ie has a high chance of introducing new bugs), then post the patch for review first. > What about other patches that aren't really code changes per se, they just > change comments and or add things to debug statements? Just commit them. Perhaps should add to the commit guidelines that documentation updates can go in without review. > And then we got patches in the tracker that are many months old. > Since it has been longer than 48 hours, those are ok to integrate? Use common sense. :-) Some of these patches are many months for a reason. > And finally, you should also add a 'modify the changelog when patch is > integrated' rule. Unless we go with just svn log dumps of what was done? > Also, more descriptive comments in the svn log while committing would also > be a good rule. I agree. - Per _______________________________________________ Warzone-dev mailing list [email protected] https://mail.gna.org/listinfo/warzone-dev
