On Mon, Aug 25, 2008 at 2:41 AM, Giel van Schijndel <[EMAIL PROTECTED]> wrote: > Then lets discuss it now. Unfortunately I'm not too good at estimating > what kind of changes you would like to discuss before committing and > which not.
Then try to err on the side of caution. >> So my most pertinent question. What is wrong with >> >> void checkDroid(const DROID *droid, const int line, const char >> *file); >> >> /* assert if droid is bad */ >> #define CHECK_DROID(droid) checkDroid(droid, __LINE__, __FILE__) >> >> ? ... > Just to get this straight: the only thing you don't like about that ^^ > change is the change from __LINE__ + __FILE__ to AT_MACRO? No. I simply do not understand what your patch is all about. What is the purpose of ASSERT_HELPER, for instance? A macro to send in __LINE__ and __FILE__ would have done the job with a lot less noise . Most of the lines of code changed just seem totally pointless/random to me. Try to explain it to me. - Per _______________________________________________ Warzone-dev mailing list [email protected] https://mail.gna.org/listinfo/warzone-dev
