#770: Sound patch which should vastly help our sound issues.
-----------------------+----------------------------------------------------
 Reporter:  Buginator  |              Owner:                  
     Type:  defect     |             Status:  new             
 Priority:  major      |          Milestone:  unspecified     
Component:  other      |            Version:  unspecified     
 Keywords:             |   Operating_system:  All/Non-Specific
Blockedby:             |           Blocking:                  
-----------------------+----------------------------------------------------

Comment(by Buginator):

 Replying to [comment:3 cybersphinx]:
 > Had a look at soundPatchNSM2.patch - you have some distracting
 whitespace changes in that. In sound_SetObjectPosition you could do "if
 (!psSample) return;" to prevent some of that. The changes in
 track.h/tracklib.h seem completely unnecessary.
 >
 > Then in some places you add "f" to float constants, but in other places
 you add them without "f". And is a comparison to 0.0 really useful (since
 floats can have some precision problems)? Especially when you test for the
 volume to not play samples, a very small value like 0.00001 seems better
 to me.


 For the whiespace changes, most of the patch is from a bigger patch, and I
 didn't have time to fix everything correctly.

 For the lack of "f" on floating point stuff, I just forgot.  As for the
 0.0f vs 0.00001f not really sure there would be much of a difference
 there.

 Uploading a newer version.

-- 
Ticket URL: <http://developer.wz2100.net/ticket/770#comment:5>
Warzone 2100 Trac <http://developer.wz2100.net/>
The Warzone 2100 Resurrection Project
_______________________________________________
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev

Reply via email to