----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3882/#review5128 -----------------------------------------------------------
"a/C://wintmp//Par1B9.tmp//ParticipantController-HEAD-left.java" <https://reviews.apache.org/r/3882/#comment11230> Can we extract this code that handles building of participants into separate method? Also it would be great to add a unit tests for this new method. "a/C://wintmp//Par1B9.tmp//ParticipantController-HEAD-left.java" <https://reviews.apache.org/r/3882/#comment11231> I think it would be better first to validate all participants and add them all only in case all addresses are valid - kind of "all or nothing" transaction. - Yuri On 2012-02-13 22:56:00, rocklund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3882/ > ----------------------------------------------------------- > > (Updated 2012-02-13 22:56:00) > > > Review request for wave. > > > Summary > ------- > > Implemented as suggested in the jira-issue as a client side implementation in > ParticipantController.java. I selected the separator for the multiple > participant list to be semi-colon(;). > > > This addresses bug wave-317. > https://issues.apache.org/jira/browse/wave-317 > > > Diffs > ----- > > "a/C://wintmp//Par1B9.tmp//ParticipantController-HEAD-left.java" ec9e25a > > Diff: https://reviews.apache.org/r/3882/diff > > > Testing > ------- > > Compiled and run. > > * Tested to add single as well as multiple participants > * Tested to add participants both with and without @localhost > * Tested to add invalid participants > > > Thanks, > > rocklund > >
