----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3882/#review5197 -----------------------------------------------------------
test/org/waveprotocol/wave/client/wavepanel/impl/edit/ParticipantControllerTest.java <https://reviews.apache.org/r/3882/#comment11382> Why not use assertEquals rather than assert true. For example: assertEqual(String message, int expected, int actual) This will provide better output during test execution. - Michael On 2012-02-16 19:19:37, rocklund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3882/ > ----------------------------------------------------------- > > (Updated 2012-02-16 19:19:37) > > > Review request for wave. > > > Summary > ------- > > Implemented as suggested in the jira-issue as a client side implementation in > ParticipantController.java. I selected the separator for the multiple > participant list to be semi-colon(;). > > > This addresses bug wave-317. > https://issues.apache.org/jira/browse/wave-317 > > > Diffs > ----- > > > src/org/waveprotocol/wave/client/wavepanel/impl/edit/ParticipantController.java > ec9e25a > > test/org/waveprotocol/wave/client/wavepanel/impl/edit/ParticipantControllerTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3882/diff > > > Testing > ------- > > Compiled and run. > > * Tested to add single as well as multiple participants > * Tested to add participants both with and without @localhost > * Tested to add invalid participants > > > Thanks, > > rocklund > >
