-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3882/
-----------------------------------------------------------
(Updated 2012-02-15 22:54:41.751527)
Review request for wave.
Changes
-------
* Broke out creation of participant list to new method in ParticipantIdUtil
* Created unit test for the new method
* Changed the separator from semi-colon to comma (@Michael: I actually had
failed to see that it said comma in the bug even though I looked for it :))
* Updated the dialog text to mention the separator
Summary
-------
Implemented as suggested in the jira-issue as a client side implementation in
ParticipantController.java. I selected the separator for the multiple
participant list to be semi-colon(;).
This addresses bug wave-317.
https://issues.apache.org/jira/browse/wave-317
Diffs (updated)
-----
src/org/waveprotocol/wave/client/wavepanel/impl/edit/ParticipantController.java
ec9e25a
src/org/waveprotocol/wave/model/wave/ParticipantId.java a5dbdf6
test/org/waveprotocol/wave/model/wave/ParticipantIdTest.java 58a2772
Diff: https://reviews.apache.org/r/3882/diff
Testing
-------
Compiled and run.
* Tested to add single as well as multiple participants
* Tested to add participants both with and without @localhost
* Tested to add invalid participants
Thanks,
rocklund
