----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5377/#review8343 -----------------------------------------------------------
Looking at the original Jira issue the proposal was for this: Not editing: Edit | Reply | Delete | Link Editing: Done | Delete | Link However, it seems like when you are in edit mode, all of the links are removed except for the (eventual) done button. This doesn't seem like what was mentioned in the issue. - Michael MacFadden On June 17, 2012, 2:24 p.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5377/ > ----------------------------------------------------------- > > (Updated June 17, 2012, 2:24 p.m.) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, Jeremy Naegel, and > Ali Lown. > > > Description > ------- > > This patch addresses part of WAVE-349 issue, that is, while editing the rest > of buttons are disabled, so people doesn't kits "reply" instead of edit (a > common usability problem). Also changes the order of the buttons to maintain > the edit button position. > > It's pending to rename the Edit button, to Done, while editing (or to add a > new button). > > > Diffs > ----- > > src/org/waveprotocol/wave/client/wavepanel/impl/edit/EditSession.java > df9357a > src/org/waveprotocol/wave/client/wavepanel/view/IntrinsicBlipMetaView.java > 26e99b2 > > src/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipMetaViewBuilder.java > 9ec4aaf > > Diff: https://reviews.apache.org/r/5377/diff/ > > > Testing > ------- > > Tested the normal use of the editor. > > > Thanks, > > Vicente J. Ruiz Jurado > >
