> On June 18, 2012, 7:15 p.m., Michael MacFadden wrote: > > Looking at the original Jira issue the proposal was for this: > > > > Not editing: Edit | Reply | Delete | Link > > Editing: Done | Delete | Link > > > > However, it seems like when you are in edit mode, all of the links are > > removed except for the (eventual) done button. This doesn't seem like what > > was mentioned in the issue. > > > > Ali Lown wrote: > Why would we ever want the 'link' button whilst editing? As for having > Done | Delete, that seems like a bad idea since the target area is so small, > I suspect it would be quite easy to click delete when you wanted done. > (Compounded by the fact both share the same letter). > > As such, despite the difference between the issue and this > implementation, I feel that this implementation is better. > > Michael MacFadden wrote: > I think there are two things to consider. First, the initial bug > registered was simply to rename the Edit Button to Delete, as to remove > confusion over which button to click when you are done editing. I think we > should attack that first since that is something that I think we (for the > most part agree on). > > What to do with the other buttons is a little more complicated. For > example, if we implement the blip controls as a tool bar with buttons, rather > than removing things, I would vote for disabling them. Also, you may have a > point in terms of which buttons the user would or would not like to leverage > when editing, but I don't think we have really explored that. For example, > if I was editing a blip and wanted you to help me with it, I sure might click > the link button and then send you a chat message saying, "Hey come take a > look at this with me". This may or may not be a valid use case. My point is > simply that I don't think we have explored all of the usability issues around > those.
What about Not editing: Edit | Reply | Delete | Link Editing: Done | Reply | Delete | Link but with the 3 last ones in Edit mode grayed out (still functional but less visible)? - Jeremy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5377/#review8343 ----------------------------------------------------------- On June 17, 2012, 2:24 p.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5377/ > ----------------------------------------------------------- > > (Updated June 17, 2012, 2:24 p.m.) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, Jeremy Naegel, and > Ali Lown. > > > Description > ------- > > This patch addresses part of WAVE-349 issue, that is, while editing the rest > of buttons are disabled, so people doesn't kits "reply" instead of edit (a > common usability problem). Also changes the order of the buttons to maintain > the edit button position. > > It's pending to rename the Edit button, to Done, while editing (or to add a > new button). > > > Diffs > ----- > > src/org/waveprotocol/wave/client/wavepanel/impl/edit/EditSession.java > df9357a > src/org/waveprotocol/wave/client/wavepanel/view/IntrinsicBlipMetaView.java > 26e99b2 > > src/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipMetaViewBuilder.java > 9ec4aaf > > Diff: https://reviews.apache.org/r/5377/diff/ > > > Testing > ------- > > Tested the normal use of the editor. > > > Thanks, > > Vicente J. Ruiz Jurado > >
