I think perhaps we are still discussing this one. On Jun 25, 2012, at 10:27 AM, Yuri Zelikov wrote:
> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5377/ > > Ship it! > > LGTM - I ll format the line and commit the patch. > > src/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipMetaViewBuilder.java > (Diff revision 1) > public String getDomId(String baseId) { > 88 > public final static Set<MenuOption> DISABLED_WHILE_EDITING_MENU_OPTIONS_SET > = EnumSet.of(IntrinsicBlipMetaView.MenuOption.REPLY, > Line too long. > > - Yuri > > > On June 17th, 2012, 2:24 p.m., Vicente J. Ruiz Jurado wrote: > > Review request for wave, Michael MacFadden, Yuri Zelikov, Jeremy Naegel, and > Ali Lown. > By Vicente J. Ruiz Jurado. > Updated June 17, 2012, 2:24 p.m. > > Description > > This patch addresses part of WAVE-349 issue, that is, while editing the rest > of buttons are disabled, so people doesn't kits "reply" instead of edit (a > common usability problem). Also changes the order of the buttons to maintain > the edit button position. > > It's pending to rename the Edit button, to Done, while editing (or to add a > new button). > Testing > > Tested the normal use of the editor. > Diffs > > src/org/waveprotocol/wave/client/wavepanel/impl/edit/EditSession.java > (df9357a) > src/org/waveprotocol/wave/client/wavepanel/view/IntrinsicBlipMetaView.java > (26e99b2) > src/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipMetaViewBuilder.java > (9ec4aaf) > View Diff >
