Title: [88107] trunk/Source/WebKit/chromium
- Revision
- 88107
- Author
- [email protected]
- Date
- 2011-06-04 03:58:47 -0700 (Sat, 04 Jun 2011)
Log Message
2011-06-04 Nico Weber <[email protected]>
Reviewed by James Robinson.
[chromium] Make PlatformMessagePortChannel's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62072
This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.
* src/PlatformMessagePortChannel.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (88106 => 88107)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-06-04 10:50:51 UTC (rev 88106)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-06-04 10:58:47 UTC (rev 88107)
@@ -2,6 +2,20 @@
Reviewed by James Robinson.
+ [chromium] Make PlatformMessagePortChannel's destructor virtual
+ https://bugs.webkit.org/show_bug.cgi?id=62072
+
+ This is _not_ to fix a real bug, just to make clang's
+ -Wdelete-non-virtual-dtor happy. As discussed at
+ http://codereview.chromium.org/7094005/, we prefer making leaf class
+ destructors virtual over making the leaf classes final.
+
+ * src/PlatformMessagePortChannel.h:
+
+2011-06-04 Nico Weber <[email protected]>
+
+ Reviewed by James Robinson.
+
[chromium] Give VoidCallbackClient a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=62067
Modified: trunk/Source/WebKit/chromium/src/PlatformMessagePortChannel.h (88106 => 88107)
--- trunk/Source/WebKit/chromium/src/PlatformMessagePortChannel.h 2011-06-04 10:50:51 UTC (rev 88106)
+++ trunk/Source/WebKit/chromium/src/PlatformMessagePortChannel.h 2011-06-04 10:58:47 UTC (rev 88107)
@@ -65,7 +65,7 @@
// Releases ownership of the contained web channel.
WebKit::WebMessagePortChannel* webChannelRelease();
- ~PlatformMessagePortChannel();
+ virtual ~PlatformMessagePortChannel();
private:
PlatformMessagePortChannel();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
