Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5670c407c90c83f96deecd9545028124725b08a7
https://github.com/WebKit/WebKit/commit/5670c407c90c83f96deecd9545028124725b08a7
Author: Lily Spiniolas <[email protected]>
Date: 2025-09-04 (Thu, 04 Sep 2025)
Changed paths:
A
LayoutTests/platform/mac-sequoia/fast/forms/switch-repaint-size-vertical-expected.txt
A
LayoutTests/platform/mac-sonoma/fast/forms/switch-repaint-size-vertical-expected.txt
A
LayoutTests/platform/mac/fast/forms/switch-repaint-size-vertical-expected.txt
A LayoutTests/platform/mac/fast/forms/switch-repaint-size-vertical.html
M Source/WebCore/rendering/mac/RenderThemeMac.mm
Log Message:
-----------
Switch controls may be sized incorrectly due to incorrect margins
https://bugs.webkit.org/show_bug.cgi?id=298334
rdar://159729284
Reviewed by Aditya Keerthi, Abrar Rahman Protyasha, and Wenson Hsieh.
In `RenderThemeMac::visualSwitchMargins`, `verticalMargins` was `static const`
despite the result depending on the passed control size. As a result,
it never updated for other control sizes on subsequent calls. Replace this logic
to ensure that subsequent calls return the correct values.
*
LayoutTests/platform/mac-sequoia/fast/forms/switch-repaint-size-vertical-expected.txt:
Added.
*
LayoutTests/platform/mac-sonoma/fast/forms/switch-repaint-size-vertical-expected.txt:
Added.
*
LayoutTests/platform/mac/fast/forms/switch-repaint-size-vertical-expected.txt:
Added.
* LayoutTests/platform/mac/fast/forms/switch-repaint-size-vertical.html: Added.
* Source/WebCore/rendering/mac/RenderThemeMac.mm:
(WebCore::visualSwitchMargins):
(WebCore::switchMargins): Deleted.
Canonical link: https://commits.webkit.org/299543@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
