Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 341dc0b24460c12569e397293378a0fa09d7d98a
https://github.com/WebKit/WebKit/commit/341dc0b24460c12569e397293378a0fa09d7d98a
Author: Alex Christensen <[email protected]>
Date: 2026-10-01 (Thu, 01 Oct 2026)
Changed paths:
M Source/WebCore/rendering/RenderVideo.cpp
M Source/WebCore/rendering/RenderVideo.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.h
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/cocoa/VideoPresentationManager.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ExitFullscreenOnEnterPiP.mm
Log Message:
-----------
Animation entering and exiting pip should start and end at correct
coordinates in a site isolated iframe
https://bugs.webkit.org/show_bug.cgi?id=325858
rdar://187141095
Reviewed by Tim Nguyen.
Convert coordinates to the main frame view instead of the root frame view, now
that that's possible.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ExitFullscreenOnEnterPiP.mm
* Source/WebCore/rendering/RenderVideo.cpp:
(WebCore::RenderVideo::videoBoxInMainFrameView const):
(WebCore::RenderVideo::videoBoxInRootView const): Deleted.
* Source/WebCore/rendering/RenderVideo.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:
(-[WKWebView _lastVideoPresentationSetupRectForTesting]):
* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.h:
(WebKit::VideoPresentationManagerProxy::lastSetupFullscreenRectForTesting
const):
* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm:
(WebKit::VideoPresentationManagerProxy::setupFullscreenWithID):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::beginTextRecognitionForVideoInElementFullScreen):
* Source/WebKit/WebProcess/cocoa/VideoPresentationManager.mm:
(WebKit::inlineVideoFrame):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ExitFullscreenOnEnterPiP.mm:
(TestWebKitAPI::TEST(ExitFullscreenOnEnterPiP,
InitialRectInSiteIsolatedIframe)):
Canonical link: https://commits.webkit.org/322413@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
