Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7983f7f0e4be04f1192b1c4a742b5ba4bfa4c0fc
https://github.com/WebKit/WebKit/commit/7983f7f0e4be04f1192b1c4a742b5ba4bfa4c0fc
Author: Ahmad Saleem <[email protected]>
Date: 2026-10-01 (Thu, 01 Oct 2026)
Changed paths:
M Source/WebCore/rendering/LegacyInlineBox.h
M Source/WebCore/rendering/LegacyInlineFlowBox.cpp
M Source/WebCore/rendering/LegacyInlineFlowBox.h
M Source/WebCore/rendering/LegacyRootInlineBox.h
Log Message:
-----------
Remove unused bitfields from LegacyInlineFlowBox and pack the remaining flags
into InlineBoxBitfields
https://bugs.webkit.org/show_bug.cgi?id=325924
rdar://188889939
Reviewed by Alan Baradlay.
m_lineBreakBidiStatusEor, m_lineBreakBidiStatusLastStrong and
m_lineBreakBidiStatusLast
are never read or written. m_baselineType is never written, so baselineType()
always
returns FontBaseline::Alphabetic. Remove all four.
The remaining LegacyInlineFlowBox flags (hasTextChildren, hasTextDescendants,
hasSelfPaintInlineBox and, when security assertions are enabled,
hasBadChildList) still
occupied their own word plus padding. Move them into LegacyInlineBox's
InlineBoxBitfields, which has spare bits. This shrinks LegacyInlineFlowBox (and
LegacyRootInlineBox) by 8 bytes, from 104 to 96 bytes in release builds.
No behavior change.
* Source/WebCore/rendering/LegacyInlineBox.h:
(WebCore::LegacyInlineBox::InlineBoxBitfields::InlineBoxBitfields):
* Source/WebCore/rendering/LegacyInlineFlowBox.cpp:
(WebCore::LegacyInlineFlowBox::setHasBadChildList):
(WebCore::LegacyInlineFlowBox::addToLine):
(WebCore::LegacyInlineFlowBox::checkConsistency const):
* Source/WebCore/rendering/LegacyInlineFlowBox.h:
(WebCore::LegacyInlineFlowBox::hasTextChildren const):
(WebCore::LegacyInlineFlowBox::hasTextDescendants const):
(WebCore::LegacyInlineFlowBox::setHasTextChildren):
(WebCore::LegacyInlineFlowBox::setHasTextDescendants):
(WebCore::LegacyInlineFlowBox::hasSelfPaintInlineBox const):
* Source/WebCore/rendering/LegacyRootInlineBox.h:
(WebCore::LegacyRootInlineBox::baselineType const):
Canonical link: https://commits.webkit.org/322430@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
