Since this seems to have become the new bikeshed, I'll chime in with my color preference: ----
Reviewed by John Smith (jsm...@webkit.org) https://bugs.webkit.org/show_bug.cgi?id=123456 Fix WebKit being not awesome enough. Make five files more awesome. ---- FWIW, I agree with those who desire to ditch the ChangeLog. WebKit is the only project I've worked on that does such a thing, and I have never gotten any benefit out of it, while I've gotten lots of headache (merge conflicts especially). On Chromium, patches are given a detailed ChangeLog-esque description which is visible in the review tool and becomes the commit log message as well (which links back to the review URL, and is also auto-pasted into the original bug report). This way from any of (bug system, commit logs, review system) you can find information about a particular patch or search for patches matching some comment. This turns out to work quite well in practice. In WebKit I try to give my patches these sorts of comments when I post them for review, but duplicating info between the ChangeLog and the review comments always makes me write less than I otherwise would, and review comments tend to get buried in the sea of noise from bugzilla. PK
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
