On Jul 2, 2009, at 11:22 AM, Timothy Hatcher wrote:
I also agree and that is the style I use.
I've always kept the "Reviewed by" on top, to me it logically goes
with the date/author line. I don't mind doing it the other way as long
as prepare-ChangeLog helps me. In the future maybe we could consider
putting it in the dateline:
2009-06-30 Maciej Stachowiak <m...@apple.com> revewied by Sam Weinig
That way all the blame goes in one place. :-)
- Maciej
On Jul 2, 2009, at 7:05 AM, Adam Roben wrote:
- I generally move the "Reviewed by" line after the bug number/
description/URL. When you're reading a ChangeLog entry/commit
message (especially an older one), it's generally much more
interesting which bug is being fixed rather than knowing who
reviewed it. (Also, putting the bug description first makes git's
one-line description of each commit much more useful than either
having a list of dates and the person who wrote the patch or
having a list of patch reviewers.)
I agree with Dave on all three points. git users gotta stick
together.
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
