Hi Yong, Sorry for r-ing a bunch of your patches last night. I tried to give you constructive comments. As you might be aware, we have a style linter now:
./WebKitTools/Scripts/check-webkit-style It might help us skip past some of the trivial review comments (like improper indenting of initializer lists). For the patches with licensing issues, I'm not sure how best to proceed. Adam On Wed, Sep 2, 2009 at 8:29 AM, Yong Li<yong...@torchmobile.com> wrote: > Thanks a lot for spending time on reviewing. As a developer, I hope I can > have more constructive comments for r-. I understand it's a hard work and > truly appreciate all of you who spend time on it. > > -Yong > > ----- Original Message ----- > From: Eric Seidel > To: WebKit Development > Sent: Wednesday, September 02, 2009 6:10 AM > Subject: [webkit-dev] Review Queue > Just your friendly reminder that the review-queue is out of control again. > We're @ 54 (was 84 on Monday): > https://bugs.webkit.org/buglist.cgi?field0-0-0=flagtypes.name&type0-0-0=equals&value0-0-0=review%3F > If a reviewers could each take a stab at r-'ing (or r+'ing!) a few patches > today we'd be back under 30 in no time... > -eric > p.s. Thanks to Adam Barth (and others) for applying the flaming sword of r- > last night. It's slightly more under control. > > ________________________________ > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
