I expect that these are less design choices, and more historical artifacts to the WebKit layer (formerly part of the glue layer) being part of src.chromium.org until yesterday! :)
-eric On Wed, Nov 11, 2009 at 10:35 AM, Eric Seidel <[email protected]> wrote: > Would one of you mind filing a bug and CCing fishd and dglazkov? > > -eric > > On Tue, Nov 10, 2009 at 12:02 PM, Adam Barth <[email protected]> wrote: >> That sounds like a bug to me. Historically the chromium port hasn't >> had a strong distinction between WebKit and WebCore/platform, but I >> think it's a worthwhile distinction to make. >> >> Adam >> >> >> On Tue, Nov 10, 2009 at 11:53 AM, Oliver Hunt <[email protected]> wrote: >>> I just noticed that there are a bunch of WebCore platform implementations >>> being landed in Chrome's WebKit API rather than in WebCore/platform. This >>> seems incorrect to me as there is no other place where this sort of >>> mis-layering occurred, the obvious files that stand out are: >>> >>> ApplicationCacheHost.cpp >>> GraphicsContext3D.cpp >>> MediaPlayerPrivateChromium.cpp >>> PlatformMessagePortChannel.* >>> ResoureHandle.cpp >>> DOMUtilitiesPrivate.* >>> >>> I see no obvious reason for these being placed in WebKit -- as far as I can >>> tell these represent a layering violation: it's not possible to build the >>> WebCore directory into it's own library due to the hard dependency on the >>> chrome webkit 'api'. >>> >>> --Oliver >>> >>> _______________________________________________ >>> webkit-dev mailing list >>> [email protected] >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >>> >> _______________________________________________ >> webkit-dev mailing list >> [email protected] >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
