Gah. I just realized this didn't go through to webkit-dev. Resending from the right email address.
On Tue, Nov 10, 2009 at 12:46 PM, Dimitri Glazkov <[email protected]> wrote: > Please pardon the dust -- upstreaming these files is just the first > step in getting a working port up. > > You're right, some of these are the artifact of extracting > inter-dependencies while staying in flight. Now that they're in WebKit > tree, we'll be able to move them into the proper places. > > :DG< > > On Tue, Nov 10, 2009 at 11:53 AM, Oliver Hunt <[email protected]> wrote: >> I just noticed that there are a bunch of WebCore platform implementations >> being landed in Chrome's WebKit API rather than in WebCore/platform. This >> seems incorrect to me as there is no other place where this sort of >> mis-layering occurred, the obvious files that stand out are: >> >> ApplicationCacheHost.cpp >> GraphicsContext3D.cpp >> MediaPlayerPrivateChromium.cpp >> PlatformMessagePortChannel.* >> ResoureHandle.cpp >> DOMUtilitiesPrivate.* >> >> I see no obvious reason for these being placed in WebKit -- as far as I can >> tell these represent a layering violation: it's not possible to build the >> WebCore directory into it's own library due to the hard dependency on the >> chrome webkit 'api'. >> >> --Oliver >> >> _______________________________________________ >> webkit-dev mailing list >> [email protected] >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
