30.03.2012, в 20:11, Darin Fisher написал(а): > I think it is a risky practice for WebKit to have half-baked "webkit" prefixed > features enabled by default on trunk.
I agree. The patch that exposed this "to be removed" attribute (<https://bugs.webkit.org/show_bug.cgi?id=82795>) also added a number of tests that are expected to fail because there is simply no implementation behind them. This too, I find unhelpful and undesirable. Landing tests with failing subtests is useful in some cases, e.g. when the test is exhaustive, and the feature is mostly working fine. But in this case, I can't see any benefit of landing tests first. The downside is quite material - it's much more difficult for reviewer of actual code change to see what test coverage is. Additional bug/commit noise has its costs, too. - WBR, Alexey Proskuryakov
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev