Skip to site navigation (Press enter)
Re: [webkit-dev] Feature Announcement: Adding
</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=webkit-dev@lists.webkit.org&q=from:%22Adam+Barth%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">Adam Barth</span></span></a></span> <span class="date"><a href="/search?l=webkit-dev@lists.webkit.org&q=date:20120501" rel="nofollow">Tue, 01 May 2012 16:05:19 -0700</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre>On Tue, May 1, 2012 at 3:50 PM, Maciej Stachowiak <m...@apple.com> wrote: > On May 1, 2012, at 3:31 PM, Eric Seidel <e...@webkit.org> wrote: >> Is your goal to be able to disable the feature to prevent a late-known >> security issue? >> >> Or is your goal to universally disable seamless for a port entirely? > > I'm not sure I understand the difference between these. The capability I'm > looking for is to disable the entire feature if necessary. However, I don't > expect that any ports Apple is involved with would leave it off indefinitely. > I hope that answers your questions.</pre><pre> One approach to ENABLE_SEAMLESS is to put the "seamless" property on HTMLIFrameElement behind [Conditional=SEAMLESS] and then to change Document::mayDisplaySeamlessWithParent to always return false. That should make the feature invisible to the web. The changes to the layout and navigation algorithms wouldn't be ifdefed, but they'll do the same things they do today because the engine won't ever treat an iframe as seamless. Adam >> On Tue, May 1, 2012 at 2:06 PM, Maciej Stachowiak <m...@apple.com> wrote: >>> >>> On May 1, 2012, at 12:20 PM, Eric Seidel <e...@webkit.org> wrote: >>> >>>> Work is complete, fully working. Passing all the tests I could come up >>>> with: >>>> <a rel="nofollow" href="https://github.com/eseidel/webkit/compare/master...seamless">https://github.com/eseidel/webkit/compare/master...seamless</a> >>>> >>>> I'm uploading and landing patches once reviewed again in bugzilla. >>>> >>>> I do not plan to add an ENABLE, as this work is complete and will all >>>> be landed by end of week, assuming timely reviews. >>> >>> I'd like to request an ENABLE for risk mitigation purposes (so anyone >>> shipping in the near future could turn it off without having to revert a >>> large patch set.) >>> >>> Regards, >>> Maciej >>> > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > <a rel="nofollow" href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a> _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org <a rel="nofollow" href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a> </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg18958.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="thrd2.html#18959">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="maillist.html#18959">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg18960.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> <li class="icons-email"><span class="subject"><a href="msg18586.html">[webkit-dev] Feature Announcement: Adding <iframe s...</a></span> <span class="sender italic">Eric Seidel</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg18588.html">Re: [webkit-dev] Feature Announcement: Adding <...</a></span> <span class="sender italic">Darin Fisher</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg18592.html">Re: [webkit-dev] Feature Announcement: Adding...</a></span> <span class="sender italic">Alexey Proskuryakov</span></li> <li class="icons-email"><span class="subject"><a href="msg18594.html">Re: [webkit-dev] Feature Announcement: Adding...</a></span> <span class="sender italic">Eric Seidel</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg18954.html">Re: [webkit-dev] Feature Announcement: Ad...</a></span> <span class="sender italic">Eric Seidel</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg18955.html">Re: [webkit-dev] Feature Announcement...</a></span> <span class="sender italic">Maciej Stachowiak</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg18956.html">Re: [webkit-dev] Feature Announc...</a></span> <span class="sender italic">Dimitri Glazkov</span></li> <li class="icons-email"><span class="subject"><a href="msg18957.html">Re: [webkit-dev] Feature Announc...</a></span> <span class="sender italic">Eric Seidel</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg18958.html">Re: [webkit-dev] Feature Ann...</a></span> <span class="sender italic">Maciej Stachowiak</span></li> <li><ul> <li class="icons-email tSliceCur"><span class="subject">Re: [webkit-dev] Feature...</span> <span class="sender italic">Adam Barth</span></li> <li class="icons-email"><span class="subject"><a href="msg18960.html">Re: [webkit-dev] Feature...</a></span> <span class="sender italic">Maciej Stachowiak</span></li> <li class="icons-email"><span class="subject"><a href="msg18963.html">Re: [webkit-dev] Feature...</a></span> <span class="sender italic">Jarred Nicholls</span></li> <li class="icons-email"><span class="subject"><a href="msg18967.html">Re: [webkit-dev] Feature...</a></span> <span class="sender italic">Maciej Stachowiak</span></li> <li class="icons-email"><span class="subject"><a href="msg18968.html">Re: [webkit-dev] Feature...</a></span> <span class="sender italic">Jarred Nicholls</span></li> <li class="icons-email"><span class="subject"><a href="msg18969.html">Re: [webkit-dev] Feature...</a></span> <span class="sender italic">Maciej Stachowiak</span></li> <li class="icons-email"><span class="subject"><a href="msg18970.html">Re: [webkit-dev] Feature...</a></span> <span class="sender italic">Adam Barth</span></li> <li class="icons-email"><span class="subject"><a href="msg18971.html">Re: [webkit-dev] Feature...</a></span> <span class="sender italic">Maciej Stachowiak</span></li> </ul> </ul> </ul> </ul> </ul> </ul> </ul> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="Re: [webkit-dev] Feature Announcement: Adding <iframe seamless>"> <input type="hidden" name="msgid" value="CAJE5ia9ZgQgiBQuM_f9q1LmAW_zLcfGHE9F+gK4pBjvLqvjq2Q@mail.gmail.com"> <input type="hidden" name="relpath" value="webkit-dev@lists.webkit.org/msg18959.html"> <input type="submit" value=" Adam Barth "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="webkit-dev@lists.webkit.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search webkit-dev"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/webkit-dev@lists.webkit.org/">webkit-dev - all messages</a></li> <li class="icons-about"><a href="/webkit-dev@lists.webkit.org/info.html">webkit-dev - about the list</a></li> <li class="icons-expand"><a href="/search?l=webkit-dev@lists.webkit.org&q=subject:%22Re%5C%3A+%5C%5Bwebkit%5C-dev%5C%5D+Feature+Announcement%5C%3A+Adding+%3Ciframe+seamless%3E%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg18958.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg18960.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> <a href="#"><img src="/webkit-dev@lists.webkit.org/logo.png" alt="webkit-dev"></a> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">CAJE5ia9ZgQgiBQuM_f9q1LmAW_zLcfGHE9F+gK4pBjvLqvjq2Q@mail.gmail.com</li> </ul> </div> </body> </html> <script>(function(){function c(){var b=a.contentDocument||a.contentWindow.document;if(b){var d=b.createElement('script');d.innerHTML="window.__CF$cv$params={r:'9cb50e082aa7984a',t:'MTc3MDY1NzgwOA=='};var a=document.createElement('script');a.src='/cdn-cgi/challenge-platform/scripts/jsd/main.js';document.getElementsByTagName('head')[0].appendChild(a);";b.getElementsByTagName('head')[0].appendChild(d)}}if(document.body){var a=document.createElement('iframe');a.height=1;a.width=1;a.style.position='absolute';a.style.top=0;a.style.left=0;a.style.border='none';a.style.visibility='hidden';document.body.appendChild(a);if('loading'!==document.readyState)c();else if(window.addEventListener)document.addEventListener('DOMContentLoaded',c);else{var e=document.onreadystatechange||function(){};document.onreadystatechange=function(b){e(b);'loading'!==document.readyState&&(document.onreadystatechange=e,c())}}}})();</script>