On Aug 22, 2013, at 12:48 AM, Mark Rowe <mr...@apple.com> wrote:

> 
> On 2013-08-22, at 12:46 AM, Carlos Garcia Campos <carlo...@webkit.org> wrote:
> 
>> El jue, 22-08-2013 a las 00:41 -0700, Mark Rowe escribió:
>>> On 2013-08-21, at 11:11 PM, Carlos Garcia Campos <carlo...@webkit.org> 
>>> wrote:
>>> 
>>>> I see, I thought ChangeLog parser was used everywhere. So, I guess the
>>>> solution would be to find a format most people like and adapt all
>>>> scripts to it. I personally think it's not worth it, though. The oneline
>>>> git log format is ok with the old commit message format IMO. If the only
>>>> problem is that the bug number is not in the first line we can probably
>>>> add it without adding the URL in angle brackets, something like:
>>>> 
>>>> Bug 119872 - REGRESSION: Crash under JITCompiler::link while loading Gmail
>>>> https://bugs.webkit.org/show_bug.cgi?id=119872
>>> 
>>> What benefit does duplicating the bug number in the first line provide? 
>>> It’s just yet another thing to have to add when writing the ChangeLog entry.
>> 
>> The benefit is that you see the bug number when using git log oneline
>> format, I'm guessing that seeing the bug number in the first line was
>> the motivation of the new ChangeLog format.
> 
> I’m ok with moving it in to the first line, but I’m against duplicating it.

I agree with this. It seems janky to include it twice.

 - Maciej

_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Reply via email to