Hi Maciej,

the first patches had the flag indeed, so it should be easy to add it back
to the patch. Not sure what's the usual procedure, but I guess it makes
sense to enable it by default in the bug so that the bots keep testing the
code? Then we'll disable it before landing if that's our decision.

Cheers,
Xan

On Thu, Feb 14, 2019 at 8:47 AM Maciej Stachowiak <m...@apple.com> wrote:

>
> I left the boring review feedback that this work should be behind a
> feature flag. Mentioning it here because this may apply to other feature
> patches you have in progress. (I am not qualified to review the substance
> of what the patch is doing.)
>
> > On Feb 13, 2019, at 1:51 PM, ca...@igalia.com wrote:
> >
> > Hi WebKitters,
> >
> > My colleagues at Igalia have been working on a number of JS language
> features! We want WebKit to have implementations in order to provide
> feedback for TC39, and to help meet the requirements to have them merged
> into the specification proper.
> >
> > Unfortunately, JSC suggested reviewers have been occupied for the past 6
> months, unable to provide feedback and help us upstream the patches. I'm
> reaching out to see if there are other folks reading webkit-dev who might
> be able to check on the work, see how it looks, and help us get this stuff
> upstream. We've been doing internal reviews, but unfortunately don't yet
> have any JSC reviewers on our team.
> >
> > You can find the patch for instance class fields at
> https://bugs.webkit.org/show_bug.cgi?id=174212. Any kind of constructive
> feedback (from anyone) would be much appreciated :)
> >
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev@lists.webkit.org
> > https://lists.webkit.org/mailman/listinfo/webkit-dev
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Reply via email to