Looks good to me. Just one remark: is this something osol specific or should this go somehow upstream?
http://cr.opensolaris.org/~sn123202/php5211.1/webrev/usr/src/cmd/php5/patches/pear_Builder_php.patch.udiff.html There are smaller indention issues, but the functionallity is okay. On 01.10.09 08:49, Seema Alevoor wrote: > > > On 10/01/09 02:41, Sriram Natarajan wrote: >> Seema >> The web rev has been updated to address your comments. >> http://cr.opensolaris.org/~sn123202/php5211.1/webrev/ >> > > Looks fine. > >>> On 09/29/09 22:33, Sriram Natarajan wrote: >>>> Seema >>>> thanks for looking into this. >>>> >>>> Seema Alevoor wrote: >>>>> Makefile.sfw : >>>>> * "--with-libxml-dir" configure option is listed twice. >>> Remove the redundant "--with-libxml-dir" option. >>> >>>>> SUNWphp52r-pear/prototype_com : >>>>> * revision version looks incorrect. >>>> i will make sure, it has redelget on it. >>>>> Previous one is 1.2 whereas the latest one is 1.4 >>>>> * Should we preserve the files within "pear/.channels" dir ? >>>>> e.g. e renamenew var/php/5.2/pear/.channels/doc.php.net.reg >>>> i don't see any need for it at this time. >>> >>> Then remove "renamenew" class action for these files. >>> >> I think, I misunderstood you. I do want the ability to create preserve >> within pear/.channels but not sub directories within >> pear/.channels/.alias. does that make sense. my prototype file already >> has renamenew for these 3 files >> e renamenew etc/php/5.2/pear.conf 0644 root bin >> e renamenew var/php/5.2/pear/.channels/doc.php.net.reg 0644 root bin >> e renamenew var/php/5.2/pear/.channels/pear.php.net.reg 0644 root bin >> e renamenew var/php/5.2/pear/.channels/pecl.php.net.reg 0644 root bin >> e renamenew var/php/5.2/pear/.channels/__uri.reg 0644 root bin >> >> does that answer your question ? > > Yes. > > -- Seema. > >>>>> On 09/25/09 04:19, Sriram Natarajan wrote: >>>>>> Hi >>>>>> Since my initial post, PHP 5.2.11 has been released and I would >>>>>> like to integrate PHP 5.2.11 within OpenSolaris build 126 . Can >>>>>> you kindly review the below webrev >>>>>> >>>>>> http://cr.opensolaris.org/~sn123202/php5211.1/webrev/ >>>>>> >>>>>> This webrev includes following bug fixes >>>>>> >>>>>> - Upgrade php version and bundled extensions like suhosin, xdebug >>>>>> - include fix to get pecl/pear working >>>>>> - provide help with xdebug configuration to simplify working with >>>>>> netbeans >>>>>> >>>>>> - Sriram >>>>>> >>>>>> Sriram Natarajan wrote: >>>>>>> Hi >>>>>>> I would like to update php to 5.2.10. For more information on the >>>>>>> list of bugs fixed, please visit >>>>>>> http://www.php.net/ChangeLog-5.php#5.2.10 >>>>>>> >>>>>>> Please find the integration patch at >>>>>>> http://cr.opensolaris.org/~sn123202/php5210.1/webrev/php-gate.patch >>>>>>> >>>>>>> and the complete webrev report at >>>>>>> http://cr.opensolaris.org/~sn123202/php5210.1/webrev/ >>>>>>> >>>>>>> Your comments are much appreciated >>>>>>> >>>>>>> thanks >>>>>>> sriram >>>>>>> _______________________________________________ >>>>>>> >>>>>>> >>>>>>> webstack-discuss mailing list >>>>>>> webstack-discuss at opensolaris.org >>>>>>> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss >>>>>> _______________________________________________ >>>>>> >>>>>> >>>>>> webstack-discuss mailing list >>>>>> webstack-discuss at opensolaris.org >>>>>> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss > _______________________________________________ > > > webstack-discuss mailing list > webstack-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/webstack-discuss -- David Soria Parra - Software Engineer Sun Microsystems GmbH Sonnenallee 1 85551 Heimstetten Germany www.sun.de mailto: david.soriaparra at sun.com Amtsgericht Muenchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin Haering
