Sriram Natarajan wrote: > > The web rev has been updated to address your comments. > http://cr.opensolaris.org/~sn123202/php5211.1/webrev/
In Makefile.sfw, you remove - --enable-wddx \ but none of the four CRs associated with this file explains why. To which CR does this change correspond? The static /usr/src/cmd/php5/config/pear/ files seem like an ugly way out, that's unfortunate. If that's what the community is doing then I guess it is ok. On copyright.tmpl, this seems quite generic (not specific to PHP). Can't it be (or maybe is already) in a common area in SFW? Check with Norm if it can be in a shared area instead of buried in PHP sources. -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
