Jyri Virkki wrote: > Sriram Natarajan wrote: > >> The web rev has been updated to address your comments. >> http://cr.opensolaris.org/~sn123202/php5211.1/webrev/ >> > > In Makefile.sfw, you remove > - --enable-wddx \ > this is done as part of we using libxml2 instead of libexpat. this is part of CR: 6851482 > but none of the four CRs associated with this file explains why. > To which CR does this change correspond? > > > The static /usr/src/cmd/php5/config/pear/ files seem like an ugly way > out, that's unfortunate. If that's what the community is doing then I > guess it is ok. > pear community is asking users to run pear update-channel at install time. i prefer doing this. this way, customers don't have to do this at the install time. this way, we could pear working out of the box. > > On copyright.tmpl, this seems quite generic (not specific to PHP). > Can't it be (or maybe is already) in a common area in SFW? Check with > Norm if it can be in a shared area instead of buried in PHP sources. > Ok, will do. Also, as part of doing this, all the .ini files (under /etc/php/5.2/conf.d/) are created with .new . So, user will need to manually move the .new files after installation. Is this acceptable ?
- Sriram
