Sriram Natarajan wrote: > what does 'rbac' within the 'prototype' do ? > > +e rbac etc/security/exec_attr 0644 root sys > +e rbac etc/security/prof_attr 0644 root sys > +e rbac etc/user_attr 0644 root sys
It uses the ON i.rbac class action script to merge the SFW *_attr files into the ON files at package install time. I think it's smart enough to not add dupes. I say that it specifically uses the ON i.rbac script as that explains why no SFW package includes reference to i.rbac, the rules state that only the ON script is allowed. > > > also, I see the above 3 files within the prototype file. However, I > don't see 'exec_attr' being installed within the install-sfw script. > what am I missing ? > > + _install N user_attr ${ETC}/user_attr 644 > + _install N auth_attr ${RIGHTSDIR}/auth_attr 644 > + _install N prof_attr ${RIGHTSDIR}/prof_attr 644 OK, those lines are from the days when I was a relative newbie. I've removed them, but you are right, in the prototype_com it should be auth_attr not exec_attr. I don't make any changes to user_attr. I've updated the WebRev to reflect these changes. http://cr.opensolaris.org/~tekgrrl/CR-6781455/ > > > Otherwise, looks good to me. Thanks > > Couple of minor thoughts > > - MySQL 5.1 splits its database and clients libraries separately. So, > once MySQL 5.1 is integrated , you might want to depend on > SUNWmysql51lib rather than depending on SUNWmysql5u as is the case > right now. right now, it looks like one will need to install a > database to install lighttpd which doesn't make any sense. I followed the discussion and I'll reply here. ALll I can do at this time is whatever will satisfy check_deps on my SFW workspace. The SFW gatekeepers will run this after we do the putback, when I originally integrated Lighttpd there was no MySQL dependency and Mike added it by hand. Given that, I can't second guess what will be in a future update to SFW, even if the Lighttpd update and MySQL 5.1 both appear in b110 there's probably nothing that I can do. We'll change it as soon as MySQL 5.1.x is integrated. > > - lighttpd.build.env still has 2008 within the copyright That's from the deleted_files section of the Webrev, again it was form my newbie days and is not needed. Thanks Amanda