Jyri Virkki wrote: > Amanda waite wrote: > >>> Noticed the rbac changes in SUNWlighttpd14r/prototype_com but didn't >>> notice where they're coming from? Also, is that part of the upstream >>> 1.4.21 update? >>> >> I learned this rbac stuff from doing code reviews, this is apparently >> the correct way of updating rbac files, it has nothing to do with the >> Lighttpd community and I can't really see how it could be as Lighttpd >> really is a source only distribution. What were your thoughts? >> > > My main thought was whether these changes are really part of 6781455 > since that covers bringing in 1.4.21 from upstream. Or whether you're > fixing something sufficiently distinct there that you might want to > track it with a different CR which more closely describes the work. > > >
You're right, I raised a separate CR and added it to the Webrev comments for SUNWlighttpd14r/prototype_com and for install_sfw It's the kind of thing that might break something so it's good to be able to have some sort of traceback Amanda
