On Aug 12, 2008, at 12:02 AM, Sunanda Menon wrote: > > http://wikis.sun.com/display/WebStack/MySQL+51ArcCase are
Some quick comments: #0: This case is a minor update (from 5.0 to 5.1) of a component which has been ARC'd before. As such, the expectation is that the ARC case for the new one should tell the reader what exactly is different this time around. On this, the current draft unfortunately isn't very helpful. It covers everything about the integration as if it was a brand new component. I can't tell (without finding the 5.0 case, reading it and making a mental diff) what's different here. For example: - 32 and 64 bit delivered; is this new or did 5.0 have that too? - Are the listed APIs new in 5.1 or everything identical to 5.0? - Configuration; is this scheme new or same as in 5.0? - SMF being delivered; new in 5.1 or identical to 5.0? - Storage engines? What's different from 5.0? - i18n, new in 5.1? - Interfaces, which are new/old/changed? Changed how? - etc, etc... [I know the answer to most but not all the above, but not every reader does. Make life easy for reviewers!] Presenting it as an all-new case makes ARC review very hard. ARC wants to see what's new and what changed. The things which are identical to what they were in 5.0 were already approved back when the 5.0 case was approved, listing them all here again just clutters the doc and makes it hard to find what is new/changed. #1: Explain why the dtrace interfaces are Volatile. #2: Say more about the upgrade experience in the spec. Since /var has different paths for 5.0 and 5.1, will running mysql_update out of the box work? Or do I have to manually copy files around first? #3: Is 'mysql' (the CLI) linked from /usr/bin? That's the command everyone wants to run out of the box. #4: "Going by this we intend to provide support for 5.0 in Opensolaris for a minimum period of 6 months so that dependant components can migrate to MySQL 5.1 within that timeframe." That's not a call you can make by saying it in this spec. Since you'll ship 2008.11 with MySQL 5.0, it's going to be supported for as long as 2008.11 is supported. #5: Where can we find documentation for these dtrace probes?
