Gopalakrishnan Sankaran wrote: > Hi Jyri, > > I have addressed the bogus paths issue in rbconfig.rb (cr 6644643) and > have resubmitted the code for review. > ** > http://cr.opensolaris.org/~gs193864/cr6644643/ >
Gopal, this looks good. thanks -ps > **Kindly take a look at it. This fix does not cause any package > upgrading issue. I have added only gcc support as Sun Studio > does not come by default. I plan to support Sun Studio and the hence > arising package upgrading issue very soon. > > Thanks, > Gopal. > ** > ** > > >>>> Jyri Virkki wrote: >>>> >>>> >>>> >>>>> Gopalakrishnan Sankaran wrote: >>>>> >>>>> >>>>> >>>>>> Hi Siva, Jyri, >>>>>> >>>>>> I have made the changes reqd (including the appropriate #ident). I >>>>>> ran wx pbchk which returned no errors. >>>>>> >>>>>> Kindly review the code changes. >>>>>> >>>>>> http://cr.opensolaris.org/~gs193864/cr6644643/ >>>>>> >>>>>> >>>>>> >>>>> Not sure if you saw my comment from Apr.4 but the above does not >>>>> address most of them yet one way or the other (see the thread at >>>>> http://www.opensolaris.org/jive/thread.jspa?threadID=56462&tstart=0) >>>>> >>>>> >>>>> >>>>> >>>>> >>>> >>>> >>>> >>> >>> >> >> > > > -- Prashant Srinivasan F/OSS Enthusiast Sun Microsystems, Inc. http://blogs.sun.com/prashant GnuPG key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x82FBDE5A
