> *** usr/src/cmd/ruby18/Makefile.sfw > - Do not redefine GMAKE, it's already defined by Makefile.master
Jyri, doesn't $GMAKE refer to the build time location of gmake? The build time location and the runtime location of gmake are, of course, currently the same. But is it guaranteed to stay that way, if yes, we should just use $GMAKE from Makefile.master - else, we should probably stick to what we have now. The $GMAKE that Gopal is using is for compilation of native gems, and this variable is not used to build an SFWNV component. -ps Jyri Virkki wrote: > Gopalakrishnan Sankaran wrote: > >> Hi Siva, Jyri, >> >> I have made the changes reqd (including the appropriate #ident). I ran >> wx pbchk which returned no errors. >> >> Kindly review the code changes. >> >> http://cr.opensolaris.org/~gs193864/cr6644643/ >> > > Not sure if you saw my comment from Apr.4 but the above does not > address most of them yet one way or the other (see the thread at > http://www.opensolaris.org/jive/thread.jspa?threadID=56462&tstart=0) > > > -- Prashant Srinivasan F/OSS Enthusiast Sun Microsystems, Inc. http://blogs.sun.com/prashant GnuPG key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x82FBDE5A
