Prashant Srinivasan wrote: > > > *** usr/src/cmd/ruby18/Makefile.sfw > > - Do not redefine GMAKE, it's already defined by Makefile.master > > Jyri, doesn't $GMAKE refer to the build time location of gmake? The > build time location and the runtime location of gmake are, of course, > currently the same.
Interesting consideration, in that generally you don't want to leak build-machine paths into the built bits. But in this case that's a path to gmake on nevada so it'll be the path to gmake on the deployment installations of nevada (& nevada-based distros like indiana) as well. > But is it guaranteed to stay that way, if yes, we should just use > $GMAKE from Makefile.master - else, we should probably stick to what we > have now. If it were to change [which it did already, after all gmake is now in /usr/bin but the symlink remains and for compatibility will likely forever remain] then the hardcoded value would be wrong either way (it's the same value after all!) So it should not be a problem, but if it ever were, redefining it in the Makefile wouldn't do anything to fix it ;-) -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
