Sriram, It looks good to me on a quick run through. . . couple of minor changes/questions
The rm -rf's could probably stand being replaced by a single "-rm -rf" in 58 clean: 59 -rm -rf $(PHP_DIR) 60 -rm -rf $(PHP_CGI) 61 -rm -rf $(SUHOSIN_DIR) 62 -rm -rf $(TCPWRAP_DIR) 63 -rm -rf $(IDN_DIR) In the depend file for SUNWapch22m-php5: 43 P SUNWcar Core Architecture, (Root) 44 P SUNWcakr Core Solaris Kernel Architecture (Root) 45 P SUNWkvm Core Architecture, (Kvm) 46 P SUNWcsr Core Solaris, (Root) 47 P SUNWckr Core Solaris Kernel (Root) 48 P SUNWcnetr Core Solaris Network Infrastructure (Root) 49 P SUNWcsu Core Solaris, (Usr) 50 P SUNWcsd Core Solaris Devices 51 P SUNWcsl Core Solaris Libraries 52 P SUNWlexpt libexpat - XML parser library 53 P SUNWlibmsr Math & Microtasking Libraries (Root) Do all of the dependencies on Solaris need to be explicitly mentioned . . . or is it sufficient to state the dependency on SUNWphp524core?(I'm not certain here, just checking). -ps Sriram Natarajan wrote: > Hi > Kindly find the webrev for PHP5 More Features > > http://cr.opensolaris.org/~sn123202/PHP5_ARC_CASE_2007_656/ > > Note: > > Support for MySQL extension (as captured in PSARC/2007/656 ARC case) > will be integrated separately and hopefully in time for build 79. > > Support for PEAR, memcached (as captured in PSARC/2007/656 ARC case) > will be integrated post build 79. > > thanks > sriram > > -- Prashant Srinivasan F/OSS Enthusiast Sun Microsystems, Inc. http://blogs.sun.com/prashant GnuPG key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x82FBDE5A
