Hi Rahul, From a quick first pass and based on those that I read and take part in on sfwnv-discuss:
I'd suggest updating all of the Copyright headers of the changed files to 2009. You could also adjust the CDDL headers to be exactly as they are here: http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes If there isn't a METADATA file then add one, you can find guidelines here: http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines In Makefile.sfw: - Use 'env -' instead of 'env' so as to make sure you only set what you want to set - Set $(VER) using the values from the METADATA file: VER=$(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh) (I realise this might be more complicated with the Squid version number) - Remove the find statements in the configure target unless you know you need them - /usr/bin/ksh93 can be replaced with $(SHELL) - Do you really need $(SPRO_VROOT)/bin in $(SFW_PATH)? In install-sfw - I'd suggest that you use ksh93 as described here:: Roland Mainz wrote: > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* > and add a > $ set -o errexit # at the beginning and replace > ". > ${SRC}/tools/install.subr" with > "source ${SRC}/tools/install.subr" (the idea is to > catch failures in the script and abort it at that > point, right now the script will just continue) - From looking at the script, it seems that the man pages are being installed with '_install N' which means that they have no sunman-stability information. - The binaries and libraries are also installed with '_install N' which means that they aren't stripped, you can either install them with '_install D' (libs) or '_install E' (executables). You can also use the post_process and post_process_so scripts to strip them as required by SFW. In the pkginfo.tmpl - Generally the version name is included in Parentheses in the DESC field. It will probably get picked up if you submit the code review to sfwnv-discuss Amanda rahul wrote: > Hi, > The WebRev for updating Squid in OpenSolaris to 2.7 STABLE5 is here > http://cr.opensolaris.org/~vrthra/6787046-squid/ > > Please do review. > > > Rahul > > _______________________________________________ > > > webstack-discuss mailing list > webstack-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/webstack-discuss >
