Updated webrev with the suggested changes is posted here http://cr.opensolaris.org/~vrthra/6787046-squid/
Please do have a look. | I'd suggest updating all of the Copyright headers of the changed files | to 2009. You could also adjust the CDDL headers to be exactly as they | are here: - done | If there isn't a METADATA file then add one, you can find guidelines | here: http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines - added | In Makefile.sfw: | - Use 'env -' instead of 'env' so as to make sure you only set what you - done | - Set $(VER) using the values from the METADATA file: | VER=$(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh) - done | - Remove the find statements in the configure target unless you know - done | - /usr/bin/ksh93 can be replaced with $(SHELL) | - Do you really need $(SPRO_VROOT)/bin in $(SFW_PATH)? - done | | In install-sfw | - I'd suggest that you use ksh93 as described here:: - done | - From looking at the script, it seems that the man pages are being | installed with '_install N' which means that they have no | sunman-stability information. - changed to use sunman script | - The binaries and libraries are also installed with '_install N' which | means that they aren't stripped, you can either install them with | '_install D' (libs) or '_install E' (executables). You can also use the | post_process and post_process_so scripts to strip them as required by SFW. - changed | | In the pkginfo.tmpl | - Generally the version name is included in Parentheses in the DESC | field. It will probably get picked up if you submit the code review to - done thanks for the review. rahul -- 1. e4 _
