rahul wrote:
>
> Hi,
>     The WebRev for updating Squid in OpenSolaris to 2.7 STABLE5 is here
> http://cr.opensolaris.org/~vrthra/6787046-squid/

METADATA:
  - OWNER field as written is not a globally unique identifier 
    (hint: use your email ;-)
  - OSR is incorrect, the shown number is (a) for Sun Web Stack and 
    (b) a cancelled OSR.  Find out correct OSR# for SFW squid (should be
    same as before).

Makefile.sfw:
  - The
-                --enable-wccp \
-                --enable-wccpv2 \
    part looks confusing until one reads this email thread. To document
    the why of those changes, add a Comment to the CR explaining it.

sunman-stability:
  - This says "Volatile" which is incorrect.  Reading WSARC/2007/554
    there are no Volatile exported interfaces. Whatever is in the man
    page must match what was actually documented in the ARC case.

usr/src/pkgdefs/SUNWsquidr/prototype_com:
  - Nothing seems to actually have changed in this file. Did something change?


usr/src/pkgdefs/SUNWsquidu/prototype_com:
  - There's a new file usr/squid/libexec/logfile-daemon, anything interesting
    feature-wise or just project private bug fix changes?



-- 
Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems

Reply via email to