Hi Susan, I tried it out. All works fine, except, you have "driver = weewx.user.HP1000DRIVER" in the weewx.conf in your install.py. It should be "driver = user.HP1000". Otherwise, it seems to be working, on my Saturday evening.
By the way, there are still some Mac-isms in your tar file, such as HP1000/._install.py. They didn't seem to bother anyone. Cheers, Bob On Saturday, January 21, 2017 at 9:41:13 PM UTC-8, [email protected] wrote: > > Thanks for the comments and suggestions. > > I read the comments on Friday (my time) and then spent today (Sunday) > making some revisions: > - changed the name to HP1000 > - added the loop delay parameter (default of 15 seconds) and associated > code > - added the default/error checking around reading in the parameters > - re-wrote the readme.md file with the markdown format > - downloaded pycharm and looked at the comments it made. I've cleaned up > some of the points but I've also not yet taken up a number of the 'style' > comments (also the comments about using snake_case and the like) - they > will probably take a bit longer > - recreated the .tar.gz file (attached) and made sure that I removed the > ".DS_Store" file that MacOS puts in - I noticed that having these seems to > upset the "wee_extension --list" command > > Of course I then realised that you have made a number of other > suggestions. I'll look at those shortly but, to be honest, at this stage > I'm more concerned about making sure that the functionality works. Style is > great (and I'm learning Python so I'm probably carrying over a whole lot of > bad habits form other programming languages) but I can clean them up a bit > later on. > > The network loss handling will definitely be the next thing on the list. > > Susan > >
