It *does in fact alter* existing translations.

The skin I use has a lang/de.conf file, the contents of

[Almanac]

    # The labels to be used for the phases of the moon:
    moon_phases = Neumond, Zunehmender Sichelmond, Zunehmender Halbmond, 
Zunehmender Mond, Vollmond, Abnehmender Mond, Abnehmender Halbmond, 
Abnehmender Sichelmond

were overwritten during the merge when installing weewx-skyfield-almanac. 
Maybe there is an option to let the merge prefer existing keys, but this 
won't solve the issue that the merged configs will be overwritten by 
installing an updated version of the skin.

Since it is the users decision to install whatever extension, I'll let it 
up to the user to have translations for any skyfield related stuff. I'd 
never expect any extension to mess with the configs of another extension, 
it's asking for issues by design. As an extension author dealing with 
almanac stuff and celestial bodies, I'd prepare the translations in the 
extensions lang file, just as I did with pyephem before, for as long no 
other way providing augmenting translations exists. This would require an 
additional layer in the processing order 
<https://www.weewx.com/docs/5.2/custom/custom-reports/?h=processing+order#processing-order>
 under 
weewx/defaults.py and above skin.conf



Karen K schrieb am Donnerstag, 27. November 2025 um 06:43:56 UTC+1:

> [email protected] schrieb am Donnerstag, 27. November 2025 um 05:19:43 
> UTC+1:
>
> Thanks for the extension. Will Skyfield interfere with an existing pyephem?
>
>
> No.
>  
>
> And why does the extension installer merge other skins lang files? This 
> alters existing translations, imho not for the better. And if the other 
> extension is updated, the merged files are overwritten anyway.
>
>  
> It does not *alter* existing translations. It adds words, that are not 
> there so far.
>
> There is one system of internationalization in WeeWX only, the $gettext 
> tag. It receives the translations from the language files of the skin. If 
> an extension adds things that include text, it has to look for the 
> localized words in the skin's language files. The Sykfield almanac 
> extension adds texts only that are specific to astronomy like planet names 
> and constellation names and some labels. They are all not included in skins 
> so far, so there is nothing to interfere with. Please, consider the 
> altervative: then is would be necessary to have a long installation 
> instruction involving the user to edit all those language files by hand and 
> a lot of support issues from users who do not read instructions.
>

-- 
You received this message because you are subscribed to the Google Groups 
"weewx-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/weewx-user/ea83207e-e4d8-45fd-b460-495a1419aaf7n%40googlegroups.com.

Reply via email to