Jérôme WAGNER wrote:

Hello Lukas,

Thank you very much for this patch.

I created ticket #1075 to hold it and this ticket will be used for the
review.
http://dev.openwengo.com/trac/openwengo/trac.cgi/ticket/1075

Regarding this patch:

1) It seems that: lines 1670-1676 in udp.c are not necesaary beacuse of lines: 1634-1638

2) I suspect that removal of:
       snprintf(je->req_uri, 255, "%s", tmp);
        osip_free(tmp);
   in couple of places in jevent.c is wrong....

3) Is it so difficult to keep same indentation style as the rest of file? It simplifies maintenance



Thanks
Vadim

_______________________________________________
Wengophone-devel mailing list
[email protected]
http://dev.openwengo.com/mailman/listinfo/wengophone-devel

Reply via email to