Jerome, Got it fixed. Attached is the patch. (You pointed me in the right direction.)
I left the changes very obvious, but they can easily be cleaned up. A couple of notes: 1) I'm not that happy that the order of the calls to setCaps causes the camera to succeed or fail (though I never actually checked what happens if I put the two calls second -- given the long link times). 2) It might make more sense for setCaps to ignore the _isOpen flag, but that's for you to decide, I just hacked around it. -Lukas Lukas Oberhuber -----Original Message----- From: Jérôme WAGNER [mailto:[EMAIL PROTECTED] Sent: 19 October 2006 12:12 To: 'Lukas Oberhuber' Cc: [email protected] Subject: RE: [Wengophone-devel] branches and wifo-refactoring Thank you, that is what I meant. On this kind of laptop, the webcam is integrated. Who knows what they have hard-wired inside ;-) I'll keep you posted Jerome -----Message d'origine----- De : Lukas Oberhuber [mailto:[EMAIL PROTECTED] Envoyé : jeudi 19 octobre 2006 13:03 À : 'Jérôme WAGNER' Cc : [email protected] Objet : RE: [Wengophone-devel] branches and wifo-refactoring Jerome, I'm not sure what you mean by reference. However, if you mean the model, it is a Sony Vaio VGN-SZ1-HP/B running winXP -Lukas Lukas Oberhuber -----Original Message----- From: Jérôme WAGNER [mailto:[EMAIL PROTECTED] Sent: 19 October 2006 11:58 To: 'Lukas Oberhuber' Cc: [email protected] Subject: RE: [Wengophone-devel] branches and wifo-refactoring Hello Lukas, What is the reference of you machine ? Thanx Jérôme -----Message d'origine----- De : Lukas Oberhuber [mailto:[EMAIL PROTECTED] Envoyé : jeudi 19 octobre 2006 12:50 À : 'Jérôme WAGNER' Cc : [email protected] Objet : RE: [Wengophone-devel] branches and wifo-refactoring Jerome, Here are the results of my test: "Sony Visual Communication Camera VGP-VCC2" Only available settings are resolution and Pixel Depth and compression Resolution:PixelDepth-Palette:Result 320x240:YUY2:good picture 320x240:UYVY:no picture Other tests I ran for good measure: 160x120:YUY2:good picture 160x120:UYVY:no picture 176x144:YUY2:good picture 176x144:UYVY:no picture 352x288:UYVY:no picture 352x288:YUY2:good picture 640x480:UYVY:no picture 640x480:YUY2:good picture -Lukas Lukas Oberhuber -----Original Message----- From: Jérôme WAGNER [mailto:[EMAIL PROTECTED] Sent: 19 October 2006 08:16 To: 'Lukas Oberhuber' Cc: [email protected] Subject: RE: [Wengophone-devel] branches and wifo-refactoring Hello, I moved #1071 to the milestone called "a bag of patches" because you patch seems more satisfying than mine but I have to check on my side whether it corrects the issue I had. Regarding ticket #1072, My commit 6938 - tentative patch to handle UYVY palette format on VAIO computers with VGP VCC2 embedded camera was supposed to have corrected the problem for Vaio computers, for a webcam similar to yours. I just wrote added information on the wiki regarding how to introspect working palettes on Windows. Could you please follow the procedure on this page and send the results on the ML ? http://dev.openwengo.com/trac/openwengo/trac.cgi/wiki/HardwareSupportNg Thank you, Jérôme -----Message d'origine----- De : Lukas Oberhuber [mailto:[EMAIL PROTECTED] Envoyé : jeudi 19 octobre 2006 02:46 À : 'Jérôme WAGNER' Cc : [email protected] Objet : RE: [Wengophone-devel] branches and wifo-refactoring Jerome, I've finished building the code, merged into msvc++ 2005 and have tested the webcam. Though it no longer requires my code fix, there is still no picture. So the web cam is still not working. (#1071 can be closed but not #1072.) -Lukas Lukas Oberhuber -----Original Message----- From: Jérôme WAGNER [mailto:[EMAIL PROTECTED] Sent: 17 October 2006 08:41 To: 'Lukas Oberhuber' Cc: [email protected] Subject: RE: [Wengophone-devel] branches and wifo-refactoring Hello Lukas, Did you create tickets #1071 and #1072 regarding webcam issues ? The code you made your patch on is unfortunately not up to date with the trunk (regarding the default codec list and the webcam init phase). Could you please try an unmodified trunk and report if you have the same problem ? You _pGraph, _pBuild inversion is interesting in the code, but I would like you to also try code that is commited right now that also has a modification around these lines for some webcams. Regarding your palette issue (#1072), what webcam do you have ? I'll try and post on the wiki a specific progressive HowTo on these palette problems. They usually can be tracked down. Thank you, Jerome
DirectXWebcamDriver.patch
Description: Binary data
_______________________________________________ Wengophone-devel mailing list [email protected] http://dev.openwengo.com/mailman/listinfo/wengophone-devel
