All, For reasons I'm not clear on, eclipse's version of patch creation is quite crap, which led to this patch. I looked at all the modifications in the comparison viewer and did not realize this was the result I would get.
I think it is due to not ignoring whitespace and the difference between windows and unix end of line characters. >Regarding this patch: >1) It seems that: lines 1670-1676 in udp.c are not necesaary beacuse >of lines: 1634-1638 I think you are right. It would want some testing of course. >2) I suspect that removal of: > snprintf(je->req_uri, 255, "%s", tmp); > osip_free(tmp); > in couple of places in jevent.c is wrong.... I think this is an artifact of the diffing algorithm. They are not actually removed. I will try to create a better patch, but not sure I can because of eclipse. >3) Is it so difficult to keep same indentation style as the rest of >file? It simplifies maintenance The indentation style for this code that I see in my editors is *very* erratic. I have my editor set to use tabs of size 2. This appears to be correct in most of the wengophone code, but in the osip libraries the code looks randomly indented (on my system). In order to make changes, I had to do some organizing. Let me know what the correct setting are, but it is tricky to maintain different ones for different files. Thanks for the comments Vadim. -Lukas Lukas Oberhuber -----Original Message----- From: Vadim Lebedev [mailto:[EMAIL PROTECTED] Sent: 19 October 2006 12:35 To: Jérôme WAGNER Cc: 'Lukas Oberhuber'; [email protected] Subject: Re: [Wengophone-devel] branches and wifo-refactoring Jérôme WAGNER wrote: >Hello Lukas, > >Thank you very much for this patch. > >I created ticket #1075 to hold it and this ticket will be used for the >review. > >http://dev.openwengo.com/trac/openwengo/trac.cgi/ticket/1075 > > > Regarding this patch: 1) It seems that: lines 1670-1676 in udp.c are not necesaary beacuse of lines: 1634-1638 2) I suspect that removal of: snprintf(je->req_uri, 255, "%s", tmp); osip_free(tmp); in couple of places in jevent.c is wrong.... 3) Is it so difficult to keep same indentation style as the rest of file? It simplifies maintenance Thanks Vadim _______________________________________________ Wengophone-devel mailing list [email protected] http://dev.openwengo.com/mailman/listinfo/wengophone-devel
