Update of patch #1029 (project wesnoth):
Status: None => In Progress
Assigned to: None => boucman
_______________________________________________________
Follow-up Comment #2:
I am not sure why you changed the order of the arguments...
the argument is not properly named, wml_recall seems to specify whether the
parameter is from a WML recall or user triggered...
you make it mean whether it's a recruit or a recall
studying further, It seems the wml_recall parameter you use is already used
to see if the change was WML triggered or not.
you seem to be changing the meaning of the parameter, which is dangerous, but
you did not change the previous usage of that parameter in that function which
is VERY bad
I might have misunderstood the code, but please explain me exactly what's
going on here, so we can work on it together.
you probably need a new param to separate recruit from recall
and maybe rename wml_recall to wml_triggered, or no_random
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1029>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
