Follow-up Comment #1, patch #1148 (project wesnoth):
ok, couple of comments
don't worry the first reviews are usually full of seemongly useless stuff to
correct
please review your patch for minor useless changes like
* adding a blank space at end of line 37 of mapgen.cpp
* adding an extra space in line 587
* there are a couple more here and there..
you should proofread the patch before submiting, it's the easiest way to find
that sort of stuff
you have your own main program, that might be usefull for testing purpose,
but please remove the code before submiting
why do you declare the "dummy" variable, you could directly set the variable
to "" since string are copied correctly in this case
you didn't add yourself to data/core/about.cfg (unde misc contributors)
you didn't add a chagelog entry
hope to see more of this patch soon
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1148>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
