Follow-up Comment #5, patch #1148 (project wesnoth):
you have uselessly modified the SConstruct file
I don't understand why you have a village_name_mountain and a
village_name_mountain2... reading the code didn't help me figure it out, you
might want to either remove one of them or rename to a more significant name
you should try to only name "big forest" not sure how to do that... that's
just an idea, if it's not trivial forget it
you seem to name castle as if they were bridges...
it would be good for large features (large forests, long roads) to repeat the
name from time to time, alternatively, write the name at the center of large
features when possible
it might be nice to name castles too (two types of names: with and without
keeps)
deserts seem not to be named either
when a feature has multiple neighbouring villages, some names can repeat
themselves (because of the limited number of names) if there was a simple way
of preventing that, it would be nice (you could keep a std::set with all used
names, and try again when a duplicate name is generated. this could be
implemented directly in generate_name. Remember to limit the max number of
retries)
overall, this is a pretty good patch, you have some blocking remarks
(indentation, renaming of village_name_mountain2)
I hope to see more of this soon
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1148>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
