Follow-up Comment #2, patch #1148 (project wesnoth):
Please also check your patch for indentation; there are places where you use
spaces instead of tabs, and vice versa; this is a bit of a mess. There are
even places where you fill an empty line with spaces.
Overall, I'm concerned by the approach of this patch. Location naming was
already quite English-centric, it will get even worse. I would prefer if
there were some thoughts on improving the current system first.
Moreover, you are using the unit_race mechanism. Fortunately, your current
naming string doesn't have any common substrings. But if it had, the naming
would go horribly wrong. If you want to experience what I mean, try adding
"Glepp" (I know it doesn't mean anything, that's not the point, just imagine
there is another language where it means something) to your prefix list and
enjoys the names Wesnoth creates. (This was less of an issue with the
previous system since the naming didn't mean anything.)
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1148>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
