Follow-up Comment #6, patch #1145 (project wesnoth):
round two of comments
* please do not add an about.cfg, you already have one (you can update the
comment if you want to)
* there are still debug_print calls lying around...
* I don't see any defference between the get_free_loc and get_loc_for _one
function
* your patch is strange, it contains a lot of poison stuff, as if you hadn't
updated since that time... please make sure your repo is up to date before
generating patches
* you might consider poison, if you want to improve this patch a little
heal_improve_eval
* please add linebreaks/indentation in the "where" functions, it makes things
hard to read
* the whole checkone part seems useless to me. If size is < 2, the ckeck
formula would still work. Moreover the whole size_find is probably useless
too. if size is 0, check will return undef which is correctly handled. That
might explain the perf problem crab observed
* the block in units_can_rech seems slightly incorrect, you only check for
one neighbouring location instead of all of them
* in that last part, you don't check for regenerating units
* you should probably do a "valid target" function for units that are target
for healing instead of repeating everything every time
heal_improve_move
* finish_wounded would be better written as move(check.loc,check.loc)
unit_heal_control
* would be better named unit_heal_eval for consistancy
I am not sure that this is the best approch to healing, but it seems to
work.
We will have to test in game situation some more
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1145>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
